Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[541] remove unused application complete path #10200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

Context

while I was searching for all the ways a candidate can get to the withdraw process, I came across this route which always redirects to either carry_over, or the application_choices path... But the application choices path redirects to carry_over if appropriate, so it wasn't necessary to keep this path alive. The complete.html.erb hasn't been used since continuous applications.

Changes proposed in this pull request

No UI changes. Everything is exactly the same.
This just removes a route.

Guidance to review

Click around and see if anything is broken.

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • [] If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee
Copy link
Contributor Author

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Dec 20, 2024
@elceebee elceebee self-assigned this Dec 20, 2024
@github-actions github-actions bot temporarily deployed to review_aks-10200 December 20, 2024 15:14 Destroyed
@elceebee elceebee marked this pull request as ready for review December 20, 2024 15:48
@elceebee elceebee requested a review from a team December 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant